Commit 61eeb967 authored by Shawn Lin's avatar Shawn Lin Committed by Ulf Hansson
Browse files

pmdomain: rockchip: Check if SMC could be handled by TA 



Non-existent trusted-firmware could lead to SMC calls into some unset
location, that breaks the system. Let's check that it's supported before
executing the SMC.

Reported-by: default avatarSteven Price <steven.price@arm.com>
Suggested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Fixes: 58ebba35 ("pmdomain: rockchip: Add smc call to inform firmware")
Signed-off-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: default avatarSteven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/1739926689-151827-1-git-send-email-shawn.lin@rock-chips.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 58ebba35

drivers/pmdomain/rockchip/pm-domains.c

+4 −3
Original line number Diff line number Diff line
@@ -572,6 +572,7 @@ static void rockchip_do_pmu_set_power_domain(struct rockchip_pm_domain *pd, 
	}



	/* Inform firmware to keep this pd on or off */

	if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_NONE)

		arm_smccc_smc(ROCKCHIP_SIP_SUSPEND_MODE, ROCKCHIP_SLEEP_PD_CONFIG,

				pmu->info->pwr_offset + pd_pwr_offset,

				pd->info->pwr_mask, on, 0, 0, 0, &res);