Commit 61f5338d authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

inet: use call_rcu_hurry() in inet_free_ifa() 



This is a followup of commit c4e86b43 ("net: add two more
call_rcu_hurry()")

Our reference to ifa->ifa_dev must be freed ASAP
to release the reference to the netdev the same way.

inet_rcu_free_ifa()

	in_dev_put()
	 -> in_dev_finish_destroy()
	   -> netdev_put()

This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cd42ba1c

net/ipv4/devinet.c

+6 −1
Original line number Diff line number Diff line
@@ -224,6 +224,7 @@ static struct in_ifaddr *inet_alloc_ifa(void) 
static void inet_rcu_free_ifa(struct rcu_head *head)

{

	struct in_ifaddr *ifa = container_of(head, struct in_ifaddr, rcu_head);



	if (ifa->ifa_dev)

		in_dev_put(ifa->ifa_dev);

	kfree(ifa);
@@ -231,7 +232,11 @@ static void inet_rcu_free_ifa(struct rcu_head *head) 


static void inet_free_ifa(struct in_ifaddr *ifa)

{

	call_rcu(&ifa->rcu_head, inet_rcu_free_ifa);

	/* Our reference to ifa->ifa_dev must be freed ASAP

	 * to release the reference to the netdev the same way.

	 * in_dev_put() -> in_dev_finish_destroy() -> netdev_put()

	 */

	call_rcu_hurry(&ifa->rcu_head, inet_rcu_free_ifa);

}



static void in_dev_free_rcu(struct rcu_head *head)