Unverified Commit 622cd3da authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Konstantin Komarov
Browse files

fs/ntfs3: Slightly simplify ntfs_inode_printk() 



The size passed to snprintf() includes the space for the trailing space.
So there is no reason here not to use all the available space.

So remove the -1 when computing 'name_len'.
While at it, use the size of the array directly instead of the intermediate
'name_len' variable.

snprintf() also guaranties that the buffer if NULL terminated, so there is
no need to write an additional trailing NULL "To be sure".

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 1f5fa4b3

fs/ntfs3/super.c

+2 −3
Original line number Diff line number Diff line
@@ -122,13 +122,12 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...) 


	if (name) {

		struct dentry *de = d_find_alias(inode);

		const u32 name_len = ARRAY_SIZE(s_name_buf) - 1;



		if (de) {

			spin_lock(&de->d_lock);

			snprintf(name, name_len, " \"%s\"", de->d_name.name);

			snprintf(name, sizeof(s_name_buf), " \"%s\"",

				 de->d_name.name);

			spin_unlock(&de->d_lock);

			name[name_len] = 0; /* To be sure. */

		} else {

			name[0] = 0;

		}