Commit 6248f3dc authored by Maxime Chevallier's avatar Maxime Chevallier Committed by Jakub Kicinski
Browse files

net: phy: phy_port: Cleanup the of-parsing logic for phy_port 



We don't need to maintain a mediums bitfield, let's drop it and drop a
bogus check for empty mediums, as we already check it above.

Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarChristophe Leroy (CS GROUP) <chleroy@kernel.org>
Link: https://patch.msgid.link/20260205092317.755906-3-maxime.chevallier@bootlin.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 05616671

drivers/net/phy/phy_port.c

+2 −7
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ struct phy_port *phy_of_parse_port(struct device_node *dn) 
	enum ethtool_link_medium medium;

	struct phy_port *port;

	const char *med_str;

	u32 pairs = 0, mediums = 0;

	u32 pairs = 0;

	int ret;



	ret = fwnode_property_read_string(fwnode, "media", &med_str);
@@ -85,17 +85,12 @@ struct phy_port *phy_of_parse_port(struct device_node *dn) 
		return ERR_PTR(-EINVAL);

	}



	mediums |= BIT(medium);



	if (!mediums)

		return ERR_PTR(-EINVAL);



	port = phy_port_alloc();

	if (!port)

		return ERR_PTR(-ENOMEM);



	port->pairs = pairs;

	port->mediums = mediums;

	port->mediums = BIT(medium);



	return port;

}