Unverified Commit 6280e96f authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/atomic-helper: Change parameter name of drm_atomic_helper_cleanup_planes() 



drm_atomic_helper_cleanup_planes() is one of the final part of a commit,
and will free up all plane resources used in the previous commit.  It
takes the drm_atomic_state being committed as a parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-24-e71598f49c8f@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent e64834b5

drivers/gpu/drm/drm_atomic_helper.c

+4 −4
Original line number Diff line number Diff line
@@ -2989,10 +2989,10 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_planes_on_crtc); 
/**

 * drm_atomic_helper_cleanup_planes - cleanup plane resources after commit

 * @dev: DRM device

 * @old_state: atomic state object with old state structures

 * @state: atomic state object being committed

 *

 * This function cleans up plane state, specifically framebuffers, from the old

 * configuration. Hence the old configuration must be perserved in @old_state to

 * configuration. Hence the old configuration must be perserved in @state to

 * be able to call this function.

 *

 * This function may not be called on the new state when the atomic update
@@ -3000,13 +3000,13 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_planes_on_crtc); 
 * drm_atomic_helper_unprepare_planes() in this case.

 */

void drm_atomic_helper_cleanup_planes(struct drm_device *dev,

				      struct drm_atomic_state *old_state)

				      struct drm_atomic_state *state)

{

	struct drm_plane *plane;

	struct drm_plane_state *old_plane_state;

	int i;



	for_each_old_plane_in_state(old_state, plane, old_plane_state, i) {

	for_each_old_plane_in_state(state, plane, old_plane_state, i) {

		const struct drm_plane_helper_funcs *funcs = plane->helper_private;



		if (funcs->cleanup_fb)