Commit 6284e67a authored by Nikita Kravets's avatar Nikita Kravets Committed by Hans de Goede
Browse files

platform/x86: msi-ec: Fix the 3rd config 



Fix the charge control address of CONF3 and remove an incorrect firmware
version which turned out to be a BIOS firmware and not an EC firmware.

Fixes: 392cacf2 ("platform/x86: Add new msi-ec driver")
Cc: Aakash Singh <mail@singhaakash.dev>
Cc: Jose Angel Pastrana <japp0005@red.ujaen.es>
Signed-off-by: default avatarNikita Kravets <teackot@gmail.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231006175352.1753017-5-teackot@gmail.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 4d73c677

drivers/platform/x86/msi-ec.c

+1 −2
Original line number Diff line number Diff line
@@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = { 


static const char * const ALLOWED_FW_3[] __initconst = {

	"1592EMS1.111",

	"E1592IMS.10C",

	NULL

};



static struct msi_ec_conf CONF3 __initdata = {

	.allowed_fw = ALLOWED_FW_3,

	.charge_control = {

		.address      = 0xef,

		.address      = 0xd7,

		.offset_start = 0x8a,

		.offset_end   = 0x80,

		.range_min    = 0x8a,