Commit 62b5848f authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

power: sequencing: add defines for return values of the match() callback 



Instead of using 0 and 1 as magic numbers, let's add proper defines
whose names tell the reader what the meaning behind them is.

Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20250624-pwrseq-match-defines-v1-3-a59d90a951f1@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 1a7312b9

drivers/power/sequencing/core.c

+3 −3
Original line number Diff line number Diff line
@@ -628,7 +628,7 @@ static int pwrseq_match_device(struct device *pwrseq_dev, void *data) 
		return 0;



	ret = pwrseq->match(pwrseq, match_data->dev);

	if (ret <= 0)

	if (ret == PWRSEQ_NO_MATCH || ret < 0)

		return ret;



	/* We got the matching device, let's find the right target. */
@@ -651,7 +651,7 @@ static int pwrseq_match_device(struct device *pwrseq_dev, void *data) 


	match_data->desc->pwrseq = pwrseq_device_get(pwrseq);



	return 1;

	return PWRSEQ_MATCH_OK;

}



/**
@@ -684,7 +684,7 @@ struct pwrseq_desc *pwrseq_get(struct device *dev, const char *target) 
			       pwrseq_match_device);

	if (ret < 0)

		return ERR_PTR(ret);

	if (ret == 0)

	if (ret == PWRSEQ_NO_MATCH)

		/* No device matched. */

		return ERR_PTR(-EPROBE_DEFER);

include/linux/pwrseq/provider.h

+3 −0
Original line number Diff line number Diff line
@@ -13,6 +13,9 @@ struct pwrseq_device; 
typedef int (*pwrseq_power_state_func)(struct pwrseq_device *);

typedef int (*pwrseq_match_func)(struct pwrseq_device *, struct device *);



#define PWRSEQ_NO_MATCH 0

#define PWRSEQ_MATCH_OK 1



/**

 * struct pwrseq_unit_data - Configuration of a single power sequencing

 *                           unit.