Commit 62d3726d authored by Tejun Heo's avatar Tejun Heo
Browse files

sched_ext: Fix build when !CONFIG_STACKTRACE 



a2f4b16e ("sched_ext: Build fix on !CONFIG_STACKTRACE[_SUPPORT]") tried
fixing build when !CONFIG_STACKTRACE but didn't so fully. Also put
stack_trace_print() and stack_trace_save() inside CONFIG_STACKTRACE to fix
build when !CONFIG_STACKTRACE.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409220642.fDW2OmWc-lkp@intel.com/
parent edf1c586

kernel/sched/ext.c

+4 −3
Original line number Diff line number Diff line
@@ -4469,8 +4469,9 @@ static void scx_ops_disable_workfn(struct kthread_work *work) 


		if (ei->msg[0] != '\0')

			pr_err("sched_ext: %s: %s\n", scx_ops.name, ei->msg);



#ifdef CONFIG_STACKTRACE

		stack_trace_print(ei->bt, ei->bt_len, 2);

#endif

	} else {

		pr_info("sched_ext: BPF scheduler \"%s\" disabled (%s)\n",

			scx_ops.name, ei->reason);
@@ -4847,10 +4848,10 @@ static __printf(3, 4) void scx_ops_exit_kind(enum scx_exit_kind kind, 
		return;



	ei->exit_code = exit_code;



#ifdef CONFIG_STACKTRACE

	if (kind >= SCX_EXIT_ERROR)

		ei->bt_len = stack_trace_save(ei->bt, SCX_EXIT_BT_LEN, 1);



#endif

	va_start(args, fmt);

	vscnprintf(ei->msg, SCX_EXIT_MSG_LEN, fmt, args);

	va_end(args);