Commit 62e9c00e authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

eth: fbnic: don't disable the PCI device twice 



We use pcim_enable_device(), there is no need to call pci_disable_device().

Fixes: 546dd90b ("eth: fbnic: Add scaffolding for Meta's NIC driver")
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241115014809.754860-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8ffade77

drivers/net/ethernet/meta/fbnic/fbnic_pci.c

+0 −2
Original line number Diff line number Diff line
@@ -319,7 +319,6 @@ static int fbnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
free_irqs:

	fbnic_free_irqs(fbd);

free_fbd:

	pci_disable_device(pdev);

	fbnic_devlink_free(fbd);



	return err;
@@ -349,7 +348,6 @@ static void fbnic_remove(struct pci_dev *pdev) 
	fbnic_fw_disable_mbx(fbd);

	fbnic_free_irqs(fbd);



	pci_disable_device(pdev);

	fbnic_devlink_free(fbd);

}