Commit 635a9fca authored by Nicolas Bouchinet's avatar Nicolas Bouchinet Committed by Greg Kroah-Hartman
Browse files

tty: ldsic: fix tty_ldisc_autoload sysctl's proc_handler 



Commit 7c0cca7c ("tty: ldisc: add sysctl to prevent autoloading of
ldiscs") introduces the tty_ldisc_autoload sysctl with the wrong
proc_handler. .extra1 and .extra2 parameters are set to avoid other values
thant SYSCTL_ZERO or SYSCTL_ONE to be set but proc_dointvec do not uses
them.

This commit fixes this by using proc_dointvec_minmax instead of
proc_dointvec.

Fixes: 7c0cca7c ("tty: ldisc: add sysctl to prevent autoloading of ldiscs")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarNicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Reviewed-by: default avatarLin Feng <linf@wangsu.com>
Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20241112131357.49582-4-nicolas.bouchinet@clip-os.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 166105c9

drivers/tty/tty_io.c

+1 −1
Original line number Diff line number Diff line
@@ -3631,7 +3631,7 @@ static struct ctl_table tty_table[] = { 
		.data		= &tty_ldisc_autoload,

		.maxlen		= sizeof(tty_ldisc_autoload),

		.mode		= 0644,

		.proc_handler	= proc_dointvec,

		.proc_handler	= proc_dointvec_minmax,

		.extra1		= SYSCTL_ZERO,

		.extra2		= SYSCTL_ONE,

	},