Unverified Commit 636f4618 authored by Haotian Zhang's avatar Haotian Zhang Committed by Mark Brown
Browse files

regulator: fixed: fix GPIO descriptor leak on register failure 



In the commit referenced by the Fixes tag,
devm_gpiod_get_optional() was replaced by manual
GPIO management, relying on the regulator core to release the
GPIO descriptor. However, this approach does not account for the
error path: when regulator registration fails, the core never
takes over the GPIO, resulting in a resource leak.

Add gpiod_put() before returning on regulator registration failure.

Fixes: 5e6f3ae5 ("regulator: fixed: Let core handle GPIO descriptor")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251028172828.625-1-vulab@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6146a0f1

drivers/regulator/fixed.c

+1 −0
Original line number Diff line number Diff line
@@ -334,6 +334,7 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) 
		ret = dev_err_probe(&pdev->dev, PTR_ERR(drvdata->dev),

				    "Failed to register regulator: %ld\n",

				    PTR_ERR(drvdata->dev));

		gpiod_put(cfg.ena_gpiod);

		return ret;

	}