Commit 637026e5 authored Feb 14, 2025 by Jakub Kicinski

net: move stale comment about ntuple validation

Gal points out that the comment now belongs further down, since
the original if condition was split into two in
commit de7f7582 ("net: ethtool: prevent flow steering to RSS contexts which don't exist")

Link: https://lore.kernel.org/de4a2a8a-1eb9-4fa8-af87-7526e58218e9@nvidia.com

Reviewed-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20250214224340.2268691-1-kuba@kernel.org

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 24fc595e

net/ethtool/ioctl.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -992,8 +992,10 @@ static noinline_for_stack int ethtool_set_rxnfc(struct net_device *dev,
		if (rc)
		return rc;

		/* Nonzero ring with RSS only makes sense if NIC adds them together */
		if (cmd == ETHTOOL_SRXCLSRLINS && info.fs.flow_type & FLOW_RSS) {
		/* Nonzero ring with RSS only makes sense
		* if NIC adds them together
		*/
		if (!ops->cap_rss_rxnfc_adds &&
		ethtool_get_flow_spec_ring(info.fs.ring_cookie))
		return -EINVAL;