Commit 639e298f authored by Sasha Neftin's avatar Sasha Neftin Committed by Tony Nguyen
Browse files

e1000e: Fix packet loss on Tiger Lake and later 

Update the HW MAC initialization flow. Do not gate DMA clock from
the modPHY block. Keeping this clock will prevent dropped packets
sent in burst mode on the Kumeran interface.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213651
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213377


Fixes: fb776f5d ("e1000e: Add support for Tiger Lake")
Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
Tested-by: default avatarMark Pearson <markpearson@lenovo.com>
Tested-by: default avatarNechama Kraus <nechamax.kraus@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 280db5d4

drivers/net/ethernet/intel/e1000e/ich8lan.c

+10 −1
Original line number Diff line number Diff line
@@ -4813,7 +4813,7 @@ static s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw) 
static s32 e1000_init_hw_ich8lan(struct e1000_hw *hw)

{

	struct e1000_mac_info *mac = &hw->mac;

	u32 ctrl_ext, txdctl, snoop;

	u32 ctrl_ext, txdctl, snoop, fflt_dbg;

	s32 ret_val;

	u16 i;
@@ -4872,6 +4872,15 @@ static s32 e1000_init_hw_ich8lan(struct e1000_hw *hw) 
		snoop = (u32)~(PCIE_NO_SNOOP_ALL);

	e1000e_set_pcie_no_snoop(hw, snoop);



	/* Enable workaround for packet loss issue on TGP PCH

	 * Do not gate DMA clock from the modPHY block

	 */

	if (mac->type >= e1000_pch_tgp) {

		fflt_dbg = er32(FFLT_DBG);

		fflt_dbg |= E1000_FFLT_DBG_DONT_GATE_WAKE_DMA_CLK;

		ew32(FFLT_DBG, fflt_dbg);

	}



	ctrl_ext = er32(CTRL_EXT);

	ctrl_ext |= E1000_CTRL_EXT_RO_DIS;

	ew32(CTRL_EXT, ctrl_ext);

drivers/net/ethernet/intel/e1000e/ich8lan.h

+3 −0
Original line number Diff line number Diff line
@@ -289,6 +289,9 @@ 
/* Proprietary Latency Tolerance Reporting PCI Capability */

#define E1000_PCI_LTR_CAP_LPT		0xA8



/* Don't gate wake DMA clock */

#define E1000_FFLT_DBG_DONT_GATE_WAKE_DMA_CLK	0x1000



void e1000e_write_protect_nvm_ich8lan(struct e1000_hw *hw);

void e1000e_set_kmrn_lock_loss_workaround_ich8lan(struct e1000_hw *hw,

						  bool state);