Commit 63de2b38 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Catalin Marinas
Browse files

arm64/efi: Remove unneeded SVE/SME fallback preserve/store handling 



Since commit 7137a203 ("arm64/fpsimd: Permit kernel mode NEON with
IRQs off"), the only condition under which the fallback path is taken
for FP/SIMD preserve/restore across a EFI runtime call is when it is
called from hardirq or NMI context.

In practice, this only happens when the EFI pstore driver is called to
dump the kernel log buffer into a EFI variable under a panic, oops or
emergency_restart() condition, and none of these can be expected to
result in a return to user space for the task in question.

This means that the existing EFI-specific logic for preserving and
restoring SVE/SME state is pointless, and can be removed.

Instead, kill the task, so that an exceedingly unlikely inadvertent
return to user space does not proceed with a corrupted FP/SIMD state.
Also, retain the preserve and restore of the base FP/SIMD state, as that
might belong to kernel mode use of FP/SIMD. (Note that EFI runtime calls
are never invoked reentrantly, even in this case, and so any interrupted
kernel mode FP/SIMD usage will be unrelated to EFI)

Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent eb972eab

arch/arm64/kernel/fpsimd.c

+20 −110
Original line number Diff line number Diff line
@@ -180,13 +180,6 @@ static inline void set_sve_default_vl(int val) 
	set_default_vl(ARM64_VEC_SVE, val);

}



static u8 *efi_sve_state;



#else /* ! CONFIG_ARM64_SVE */



/* Dummy declaration for code that will be optimised out: */

extern u8 *efi_sve_state;



#endif /* ! CONFIG_ARM64_SVE */



#ifdef CONFIG_ARM64_SME
@@ -1095,36 +1088,6 @@ int vec_verify_vq_map(enum vec_type type) 
	return 0;

}



static void __init sve_efi_setup(void)

{

	int max_vl = 0;

	int i;



	if (!IS_ENABLED(CONFIG_EFI))

		return;



	for (i = 0; i < ARRAY_SIZE(vl_info); i++)

		max_vl = max(vl_info[i].max_vl, max_vl);



	/*

	 * alloc_percpu() warns and prints a backtrace if this goes wrong.

	 * This is evidence of a crippled system and we are returning void,

	 * so no attempt is made to handle this situation here.

	 */

	if (!sve_vl_valid(max_vl))

		goto fail;



	efi_sve_state = kmalloc(SVE_SIG_REGS_SIZE(sve_vq_from_vl(max_vl)),

				GFP_KERNEL);

	if (!efi_sve_state)

		goto fail;



	return;



fail:

	panic("Cannot allocate memory for EFI SVE save/restore");

}



void cpu_enable_sve(const struct arm64_cpu_capabilities *__always_unused p)

{

	write_sysreg(read_sysreg(CPACR_EL1) | CPACR_EL1_ZEN_EL1EN, CPACR_EL1);
@@ -1185,8 +1148,6 @@ void __init sve_setup(void) 
	if (sve_max_virtualisable_vl() < sve_max_vl())

		pr_warn("%s: unvirtualisable vector lengths present\n",

			info->name);



	sve_efi_setup();

}



/*
@@ -1947,9 +1908,6 @@ EXPORT_SYMBOL_GPL(kernel_neon_end); 
#ifdef CONFIG_EFI



static struct user_fpsimd_state efi_fpsimd_state;

static bool efi_fpsimd_state_used;

static bool efi_sve_state_used;

static bool efi_sm_state;



/*

 * EFI runtime services support functions
@@ -1976,44 +1934,27 @@ void __efi_fpsimd_begin(void) 
	if (may_use_simd()) {

		kernel_neon_begin(&efi_fpsimd_state);

	} else {

		WARN_ON(preemptible());



		/*

		 * If !efi_sve_state, SVE can't be in use yet and doesn't need

		 * preserving:

		 */

		if (system_supports_sve() && efi_sve_state != NULL) {

			bool ffr = true;

			u64 svcr;



			efi_sve_state_used = true;



			if (system_supports_sme()) {

				svcr = read_sysreg_s(SYS_SVCR);



				efi_sm_state = svcr & SVCR_SM_MASK;



		/*

				 * Unless we have FA64 FFR does not

				 * exist in streaming mode.

				 */

				if (!system_supports_fa64())

					ffr = !(svcr & SVCR_SM_MASK);

			}



			sve_save_state(efi_sve_state + sve_ffr_offset(sve_max_vl()),

				       &efi_fpsimd_state.fpsr, ffr);



			if (system_supports_sme())

				sysreg_clear_set_s(SYS_SVCR,

						   SVCR_SM_MASK, 0);



		} else {

		 * We are running in hardirq or NMI context, and the only

		 * legitimate case where this might happen is when EFI pstore

		 * is attempting to record the system's dying gasps into EFI

		 * variables. This could be due to an oops, a panic or a call

		 * to emergency_restart(), and in none of those cases, we can

		 * expect the current task to ever return to user space again,

		 * or for the kernel to resume any normal execution, for that

		 * matter (an oops in hardirq context triggers a panic too).

		 *

		 * Therefore, there is no point in attempting to preserve any

		 * SVE/SME state here. On the off chance that we might have

		 * ended up here for a different reason inadvertently, kill the

		 * task and preserve/restore the base FP/SIMD state, which

		 * might belong to kernel mode FP/SIMD.

		 */

		pr_warn_ratelimited("Calling EFI runtime from %s context\n",

				    in_nmi() ? "NMI" : "hardirq");

		force_signal_inject(SIGKILL, SI_KERNEL, 0, 0);

		fpsimd_save_state(&efi_fpsimd_state);

	}



		efi_fpsimd_state_used = true;

	}

}



/*
@@ -2024,42 +1965,11 @@ void __efi_fpsimd_end(void) 
	if (!system_supports_fpsimd())

		return;



	if (!efi_fpsimd_state_used) {

	if (may_use_simd()) {

		kernel_neon_end(&efi_fpsimd_state);

	} else {

		if (system_supports_sve() && efi_sve_state_used) {

			bool ffr = true;



			/*

			 * Restore streaming mode; EFI calls are

			 * normal function calls so should not return in

			 * streaming mode.

			 */

			if (system_supports_sme()) {

				if (efi_sm_state) {

					sysreg_clear_set_s(SYS_SVCR,

							   0,

							   SVCR_SM_MASK);



					/*

					 * Unless we have FA64 FFR does not

					 * exist in streaming mode.

					 */

					if (!system_supports_fa64())

						ffr = false;

				}

			}



			sve_load_state(efi_sve_state + sve_ffr_offset(sve_max_vl()),

				       &efi_fpsimd_state.fpsr, ffr);



			efi_sve_state_used = false;

	} else {

		fpsimd_load_state(&efi_fpsimd_state);

	}



		efi_fpsimd_state_used = false;

	}

}



#endif /* CONFIG_EFI */