Unverified Commit 63f8c058 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Ilpo Järvinen
Browse files

platform/x86: hp-bioscfg: Directly use firmware_attributes_class 



The usage of the lifecycle functions is not necessary anymore.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarArmin Wolf <W_Armin@gmx.de>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Tested-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Link: https://lore.kernel.org/r/20250104-firmware-attributes-simplify-v1-4-949f9709e405@weissschuh.net


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 55922403

drivers/platform/x86/hp/hp-bioscfg/bioscfg.c

+3 −11
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ struct bioscfg_priv bioscfg_drv = { 
	.mutex = __MUTEX_INITIALIZER(bioscfg_drv.mutex),

};



static const struct class *fw_attr_class;



ssize_t display_name_language_code_show(struct kobject *kobj,

					struct kobj_attribute *attr,

					char *buf)
@@ -972,11 +970,7 @@ static int __init hp_init(void) 
	if (ret)

		return ret;



	ret = fw_attributes_class_get(&fw_attr_class);

	if (ret)

		goto err_unregister_class;



	bioscfg_drv.class_dev = device_create(fw_attr_class, NULL, MKDEV(0, 0),

	bioscfg_drv.class_dev = device_create(&firmware_attributes_class, NULL, MKDEV(0, 0),

					      NULL, "%s", DRIVER_NAME);

	if (IS_ERR(bioscfg_drv.class_dev)) {

		ret = PTR_ERR(bioscfg_drv.class_dev);
@@ -1043,10 +1037,9 @@ static int __init hp_init(void) 
	release_attributes_data();



err_destroy_classdev:

	device_destroy(fw_attr_class, MKDEV(0, 0));

	device_destroy(&firmware_attributes_class, MKDEV(0, 0));



err_unregister_class:

	fw_attributes_class_put();

	hp_exit_attr_set_interface();



	return ret;
@@ -1055,9 +1048,8 @@ static int __init hp_init(void) 
static void __exit hp_exit(void)

{

	release_attributes_data();

	device_destroy(fw_attr_class, MKDEV(0, 0));

	device_destroy(&firmware_attributes_class, MKDEV(0, 0));



	fw_attributes_class_put();

	hp_exit_attr_set_interface();

}