Commit 6466441a authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

net: inline skb_add_rx_frag_netmem() 



This critical helper (via skb_add_rx_frag()) is mostly used
from drivers rx fast path.

It is time to inline it, this actually saves space in vmlinux:

size vmlinux.old vmlinux
   text    data     bss     dec     hex filename
37350766        23092977        4846992 65290735        3e441ef vmlinux.old
37350600        23092977        4846992 65290569        3e44149 vmlinux

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260226041213.1892561-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9ff2d2a9

include/linux/skbuff.h

+11 −2
Original line number Diff line number Diff line
@@ -2682,8 +2682,17 @@ static inline void skb_fill_page_desc_noacc(struct sk_buff *skb, int i, 
	shinfo->nr_frags = i + 1;

}



void skb_add_rx_frag_netmem(struct sk_buff *skb, int i, netmem_ref netmem,

			    int off, int size, unsigned int truesize);

static inline void skb_add_rx_frag_netmem(struct sk_buff *skb, int i,

					  netmem_ref netmem, int off,

					  int size, unsigned int truesize)

{

	DEBUG_NET_WARN_ON_ONCE(size > truesize);



	skb_fill_netmem_desc(skb, i, netmem, off, size);

	skb->len += size;

	skb->data_len += size;

	skb->truesize += truesize;

}



static inline void skb_add_rx_frag(struct sk_buff *skb, int i,

				   struct page *page, int off, int size,

net/core/skbuff.c

+0 −11
Original line number Diff line number Diff line
@@ -891,17 +891,6 @@ struct sk_buff *napi_alloc_skb(struct napi_struct *napi, unsigned int len) 
}

EXPORT_SYMBOL(napi_alloc_skb);



void skb_add_rx_frag_netmem(struct sk_buff *skb, int i, netmem_ref netmem,

			    int off, int size, unsigned int truesize)

{

	DEBUG_NET_WARN_ON_ONCE(size > truesize);



	skb_fill_netmem_desc(skb, i, netmem, off, size);

	skb->len += size;

	skb->data_len += size;

	skb->truesize += truesize;

}

EXPORT_SYMBOL(skb_add_rx_frag_netmem);



void skb_coalesce_rx_frag(struct sk_buff *skb, int i, int size,

			  unsigned int truesize)