Commit 64a37272 authored by Yang Li's avatar Yang Li Committed by David S. Miller
Browse files

team: Remove NULL check before dev_{put, hold} 



The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warning:

./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991


Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 88efedf5

drivers/net/team/team.c

+1 −2
Original line number Diff line number Diff line
@@ -2321,7 +2321,6 @@ static struct team *team_nl_team_get(struct genl_info *info) 
	ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);

	dev = dev_get_by_index(net, ifindex);

	if (!dev || dev->netdev_ops != &team_netdev_ops) {

		if (dev)

		dev_put(dev);

		return NULL;

	}