Commit 64c6a381 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Stephen Boyd
Browse files

clk: hisilicon: hi3559a: Fix an erroneous devm_kfree() 



'p_clk' is an array allocated just before the for loop for all clk that
need to be registered.
It is incremented at each loop iteration.

If a clk_register() call fails, 'p_clk' may point to something different
from what should be freed.

The best we can do, is to avoid this wrong release of memory.

Fixes: 6c819661 ("clk: hisilicon: Add clock driver for hi3559A SoC")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/773fc8425c3b8f5b0ca7c1d89f15b65831a85ca9.1705850155.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 74e39f52

drivers/clk/hisilicon/clk-hi3559a.c

+0 −1
Original line number Diff line number Diff line
@@ -491,7 +491,6 @@ static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, 


		clk = clk_register(NULL, &p_clk->hw);

		if (IS_ERR(clk)) {

			devm_kfree(dev, p_clk);

			dev_err(dev, "%s: failed to register clock %s\n",

			       __func__, clks[i].name);

			continue;