Commit 64f7548a authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Eric Biggers
Browse files

lib/crypto: sha256: Mark sha256_choose_blocks as __always_inline 



When the compiler chooses to not inline sha256_choose_blocks() in
the purgatory code, it fails to link against the missing CPU
specific version:

x86_64-linux-ld: arch/x86/purgatory/purgatory.ro: in function `sha256_choose_blocks.part.0':
sha256.c:(.text+0x6a6): undefined reference to `irq_fpu_usable'
sha256.c:(.text+0x6c7): undefined reference to `sha256_blocks_arch'
sha256.c:(.text+0x6cc): undefined reference to `sha256_blocks_simd'

Mark this function as __always_inline to prevent this, same as sha256_finup().

Fixes: 5b90a779 ("crypto: lib/sha256 - Add helpers for block-based shash")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250620191952.1867578-1-arnd@kernel.org


Signed-off-by: default avatarEric Biggers <ebiggers@kernel.org>
parent 9d4204a8

include/crypto/internal/sha2.h

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ void sha256_blocks_arch(u32 state[SHA256_STATE_WORDS], 
void sha256_blocks_simd(u32 state[SHA256_STATE_WORDS],

			const u8 *data, size_t nblocks);



static inline void sha256_choose_blocks(

static __always_inline void sha256_choose_blocks(

	u32 state[SHA256_STATE_WORDS], const u8 *data, size_t nblocks,

	bool force_generic, bool force_simd)

{