Commit 64fdf496 authored by Lucas De Marchi's avatar Lucas De Marchi
Browse files

drm/xe/guc: Fix stack_depot usage 



Add missing stack_depot_init() call when CONFIG_DRM_XE_DEBUG_GUC is
enabled to fix the following call stack:

	[] BUG: kernel NULL pointer dereference, address: 0000000000000000
	[] Workqueue:  drm_sched_run_job_work [gpu_sched]
	[] RIP: 0010:stack_depot_save_flags+0x172/0x870
	[] Call Trace:
	[]  <TASK>
	[]  fast_req_track+0x58/0xb0 [xe]

Fixes: 16b7e65d ("drm/xe/guc: Track FAST_REQ H2Gs to report where errors came from")
Tested-by: default avatarSagar Ghuge <sagar.ghuge@intel.com>
Cc: stable@vger.kernel.org # v6.17+
Reviewed-by: default avatarStuart Summers <stuart.summers@intel.com>
Link: https://patch.msgid.link/20251118-fix-debug-guc-v1-1-9f780c6bedf8@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 2e4ad5b0

drivers/gpu/drm/xe/xe_guc_ct.c

+3 −0
Original line number Diff line number Diff line
@@ -242,6 +242,9 @@ int xe_guc_ct_init_noalloc(struct xe_guc_ct *ct) 
#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)

	spin_lock_init(&ct->dead.lock);

	INIT_WORK(&ct->dead.worker, ct_dead_worker_func);

#if IS_ENABLED(CONFIG_DRM_XE_DEBUG_GUC)

	stack_depot_init();

#endif

#endif

	init_waitqueue_head(&ct->wq);

	init_waitqueue_head(&ct->g2h_fence_wq);