Commit 65226297 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Ingo Molnar
Browse files

sparc/vdso: Always reject undefined references during linking 



Instead of using a custom script to detect and fail on undefined
references, use --no-undefined for all VDSO linker invocations.

Drop the now unused checkundef.sh script.

Signed-off-by: default avatarThomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andreas Larsson <andreas@gaisler.com>
Link: https://lore.kernel.org/r/20250306-vdso-checkundef-v2-2-a26cc315fd73@linutronix.de
parent c080f2b8

arch/sparc/vdso/Makefile

+3 −4
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ targets += $(foreach x, 32 64, vdso-image-$(x).c vdso$(x).so vdso$(x).so.dbg) 


CPPFLAGS_vdso.lds += -P -C



VDSO_LDFLAGS_vdso.lds = -m elf64_sparc -soname linux-vdso.so.1 --no-undefined \

VDSO_LDFLAGS_vdso.lds = -m elf64_sparc -soname linux-vdso.so.1 \

			-z max-page-size=8192



$(obj)/vdso64.so.dbg: $(obj)/vdso.lds $(vobjs) FORCE
@@ -101,7 +101,6 @@ $(obj)/vdso32.so.dbg: FORCE \ 
quiet_cmd_vdso = VDSO    $@

      cmd_vdso = $(LD) -nostdlib -o $@ \

		       $(VDSO_LDFLAGS) $(VDSO_LDFLAGS_$(filter %.lds,$(^F))) \

		       -T $(filter %.lds,$^) $(filter %.o,$^) && \

		sh $(src)/checkundef.sh '$(OBJDUMP)' '$@'

		       -T $(filter %.lds,$^) $(filter %.o,$^)



VDSO_LDFLAGS = -shared --hash-style=both --build-id=sha1 -Bsymbolic
 
VDSO_LDFLAGS = -shared --hash-style=both --build-id=sha1 -Bsymbolic --no-undefined

arch/sparc/vdso/checkundef.sh

deleted100644 → 0
+0 −10
Original line number Diff line number Diff line 
#!/bin/sh

objdump="$1"

file="$2"

$objdump -t "$file" | grep '*UUND*' | grep -v '#scratch' > /dev/null 2>&1

if [ $? -eq 1 ]; then

    exit 0

else

    echo "$file: undefined symbols found" >&2

    exit 1

fi