Unverified Commit 65369b8e authored by Shuicheng Lin's avatar Shuicheng Lin Committed by Rodrigo Vivi
Browse files

drm/xe: Change return type of detect_bar2_dgfx() from s64 to u64 



The function never returns a negative value, and the return value is
assigned to a u64 variable. Use u64 for better type correctness
and clarity.

v2: add assert to catch theoretical negative or zero stolen size. (Rodrigo)

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
Link: https://lore.kernel.org/r/20251009230239.2830207-8-shuicheng.lin@intel.com


Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 0145a99e

drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c

+3 −1
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ static u32 get_wopcm_size(struct xe_device *xe) 
	return wopcm_size;

}



static s64 detect_bar2_dgfx(struct xe_device *xe, struct xe_ttm_stolen_mgr *mgr)

static u64 detect_bar2_dgfx(struct xe_device *xe, struct xe_ttm_stolen_mgr *mgr)

{

	struct xe_vram_region *tile_vram = xe_device_get_root_tile(xe)->mem.vram;

	resource_size_t tile_io_start = xe_vram_region_io_start(tile_vram);
@@ -105,6 +105,8 @@ static s64 detect_bar2_dgfx(struct xe_device *xe, struct xe_ttm_stolen_mgr *mgr) 
		return 0;



	stolen_size = tile_size - mgr->stolen_base;



	xe_assert(xe, stolen_size > wopcm_size);

	stolen_size -= wopcm_size;



	/* Verify usage fits in the actual resource available */