Commit 654826aa authored by Timur Tabi's avatar Timur Tabi Committed by Danilo Krummrich
Browse files

gpu: nova-core: add missing newlines to several print strings 



Although the dev_xx!() macro calls do not technically require terminating
newlines for the format strings, they should be added anyway to maintain
consistency, both within Rust code and with the C versions.

Signed-off-by: default avatarTimur Tabi <ttabi@nvidia.com>
Reviewed-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
Link: https://patch.msgid.link/20260107201647.2490140-2-ttabi@nvidia.com


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 5cf76277

drivers/gpu/nova-core/falcon.rs

+3 −3
Original line number Diff line number Diff line
@@ -469,7 +469,7 @@ fn dma_wr<F: FalconFirmware<Target = E>>( 
        if dma_start % DmaAddress::from(DMA_LEN) > 0 {

            dev_err!(

                self.dev,

                "DMA transfer start addresses must be a multiple of {}",

                "DMA transfer start addresses must be a multiple of {}\n",

                DMA_LEN

            );

            return Err(EINVAL);
@@ -492,11 +492,11 @@ fn dma_wr<F: FalconFirmware<Target = E>>( 
            .and_then(|size| size.checked_add(load_offsets.src_start))

        {

            None => {

                dev_err!(self.dev, "DMA transfer length overflow");

                dev_err!(self.dev, "DMA transfer length overflow\n");

                return Err(EOVERFLOW);

            }

            Some(upper_bound) if usize::from_safe_cast(upper_bound) > fw.size() => {

                dev_err!(self.dev, "DMA transfer goes beyond range of DMA object");

                dev_err!(self.dev, "DMA transfer goes beyond range of DMA object\n");

                return Err(EINVAL);

            }

            Some(_) => (),

drivers/gpu/nova-core/falcon/hal/ga102.rs

+2 −2
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ fn signature_reg_fuse_version_ga102( 
    let ucode_idx = match usize::from(ucode_id) {

        ucode_id @ 1..=regs::NV_FUSE_OPT_FPF_SIZE => ucode_id - 1,

        _ => {

            dev_err!(dev, "invalid ucode id {:#x}", ucode_id);

            dev_err!(dev, "invalid ucode id {:#x}\n", ucode_id);

            return Err(EINVAL);

        }

    };
@@ -66,7 +66,7 @@ fn signature_reg_fuse_version_ga102( 
    } else if engine_id_mask & 0x0400 != 0 {

        regs::NV_FUSE_OPT_FPF_GSP_UCODE1_VERSION::read(bar, ucode_idx).data()

    } else {

        dev_err!(dev, "unexpected engine_id_mask {:#x}", engine_id_mask);

        dev_err!(dev, "unexpected engine_id_mask {:#x}\n", engine_id_mask);

        return Err(EINVAL);

    };

drivers/gpu/nova-core/fb.rs

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ pub(crate) fn unregister(&self, bar: &Bar0) { 
            let _ = hal.write_sysmem_flush_page(bar, 0).inspect_err(|e| {

                dev_warn!(

                    &self.device,

                    "failed to unregister sysmem flush page: {:?}",

                    "failed to unregister sysmem flush page: {:?}\n",

                    e

                )

            });

drivers/gpu/nova-core/gpu.rs

+1 −1
Original line number Diff line number Diff line
@@ -268,7 +268,7 @@ pub(crate) fn new<'a>( 
            // We must wait for GFW_BOOT completion before doing any significant setup on the GPU.

            _: {

                gfw::wait_gfw_boot_completion(bar)

                    .inspect_err(|_| dev_err!(pdev.as_ref(), "GFW boot did not complete"))?;

                    .inspect_err(|_| dev_err!(pdev.as_ref(), "GFW boot did not complete\n"))?;

            },



            sysmem_flush: SysmemFlush::register(pdev.as_ref(), bar, spec.chipset)?,

drivers/gpu/nova-core/gsp/boot.rs

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ fn run_fwsec_frts( 
        if frts_status != 0 {

            dev_err!(

                dev,

                "FWSEC-FRTS returned with error code {:#x}",

                "FWSEC-FRTS returned with error code {:#x}\n",

                frts_status

            );