Commit 655614ea authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: net: fix counting totals when some checks fail 

Totals currently only pay attention to exceptions, if check fails
(say ksft_eq()) the test case will be counted as pass:

  # At /ksft/drivers/net/./ping.py line 18:
  # Check failed 1 != 2
  not ok 1 ping.test_v4
  ok 2 ping.test_v6
  ok 3 ping.test_tcp
  # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
            ^^^^^^^^^^^^^

Pay attention to the result.

Fixes: b86761ff ("selftests: net: add scaffolding for Netlink tests in Python")
Link: https://lore.kernel.org/r/20240417231146.2435572-2-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 41e3ddb2

tools/testing/selftests/net/lib/py/ksft.py

+4 −1
Original line number Diff line number Diff line
@@ -106,7 +106,10 @@ def ksft_run(cases, args=()): 
            continue



        ktap_result(KSFT_RESULT, cnt, case)

        if KSFT_RESULT:

            totals['pass'] += 1

        else:

            totals['fail'] += 1



    print(

        f"# Totals: pass:{totals['pass']} fail:{totals['fail']} xfail:{totals['xfail']} xpass:0 skip:{totals['skip']} error:0"