Commit 65b3ffe0 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

rxrpc: Fix rack timer warning to report unexpected mode 



rxrpc_rack_timer_expired() clears call->rack_timer_mode to OFF before
the switch. The default case warning therefore always prints OFF and
doesn't identify the unexpected timer mode.

Log the saved mode value instead so the warning reports the actual
unexpected rack timer mode.

Fixes: 7c482665 ("rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]")
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarJeffrey Altman <jaltman@auristor.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: stable@kernel.org
Link: https://patch.msgid.link/20260408121252.2249051-8-dhowells@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b33f5741

net/rxrpc/input_rack.c

+1 −1
Original line number Diff line number Diff line
@@ -413,6 +413,6 @@ void rxrpc_rack_timer_expired(struct rxrpc_call *call, ktime_t overran_by) 
		break;

	//case RXRPC_CALL_RACKTIMER_ZEROWIN:

	default:

		pr_warn("Unexpected rack timer %u", call->rack_timer_mode);

		pr_warn("Unexpected rack timer %u", mode);

	}

}