Commit 65bb9fb0 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: update comment for btrfs_set_inode_full_sync() about locking 



Nowadays we have a lock used to synchronize mmap writes with reflink and
fsync operations (struct btrfs_inode::i_mmap_lock), so update the comment
for btrfs_set_inode_full_sync() to mention that it can also be called
while holding that mmap lock. Besides being a valid alternative to the
inode's VFS lock, we already have the extent map shrinker using that mmap
lock instead.

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 956a17d9

fs/btrfs/btrfs_inode.h

+5 −3
Original line number Diff line number Diff line
@@ -381,9 +381,11 @@ static inline void btrfs_set_inode_last_sub_trans(struct btrfs_inode *inode) 
}



/*

 * Should be called while holding the inode's VFS lock in exclusive mode or in a

 * context where no one else can access the inode concurrently (during inode

 * creation or when loading an inode from disk).

 * Should be called while holding the inode's VFS lock in exclusive mode, or

 * while holding the inode's mmap lock (struct btrfs_inode::i_mmap_lock) in

 * either shared or exclusive mode, or in a context where no one else can access

 * the inode concurrently (during inode creation or when loading an inode from

 * disk).

 */

static inline void btrfs_set_inode_full_sync(struct btrfs_inode *inode)

{