Commit 66195855 authored by Taehee Yoo's avatar Taehee Yoo Committed by Jakub Kicinski
Browse files

eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic 



When a queue is restarted, it sets MRU to 0 for stopping packet flow.
MRU variable is a member of vnic_info[], the first vnic_info is default
and the second is ntuple.
Only when ntuple is enabled(ethtool -K eth0 ntuple on), vnic_info for
ntuple is allocated in init logic.
The bp->nr_vnics indicates how many vnic_info are allocated.
However bnxt_queue_{start | stop}() accesses vnic_info[BNXT_VNIC_NTUPLE]
regardless of ntuple state.

Reviewed-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Fixes: b9d2956e ("bnxt_en: stop packet flow during bnxt_queue_stop/start")
Signed-off-by: default avatarTaehee Yoo <ap420073@gmail.com>
Link: https://patch.msgid.link/20250309134219.91670-4-ap420073@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ca2456e0

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+2 −2
Original line number Diff line number Diff line
@@ -15643,7 +15643,7 @@ static int bnxt_queue_start(struct net_device *dev, void *qmem, int idx) 
	cpr = &rxr->bnapi->cp_ring;

	cpr->sw_stats->rx.rx_resets++;



	for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {

	for (i = 0; i <= bp->nr_vnics; i++) {

		vnic = &bp->vnic_info[i];



		rc = bnxt_hwrm_vnic_set_rss_p5(bp, vnic, true);
@@ -15671,7 +15671,7 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx) 
	struct bnxt_vnic_info *vnic;

	int i;



	for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {

	for (i = 0; i <= bp->nr_vnics; i++) {

		vnic = &bp->vnic_info[i];

		vnic->mru = 0;

		bnxt_hwrm_vnic_update(bp, vnic,