Commit 663385f9 authored by Lucas De Marchi's avatar Lucas De Marchi Committed by Sami Tolvanen
Browse files

module: Simplify warning on positive returns from module_init() 



It should now be rare to trigger this warning - it doesn't need to be so
verbose. Make it follow the usual style in the module loading code.

For the same reason, drop the dump_stack().

Suggested-by: default avatarPetr Pavlu <petr.pavlu@suse.com>
Signed-off-by: default avatarLucas De Marchi <demarchi@kernel.org>
Reviewed-by: default avatarAaron Tomlin <atomlin@atomlin.com>
Reviewed-by: default avatarPetr Pavlu <petr.pavlu@suse.com>
Reviewed-by: default avatarDaniel Gomez <da.gomez@samsung.com>
Signed-off-by: default avatarSami Tolvanen <samitolvanen@google.com>
parent 743f8cae

kernel/module/main.c

+3 −7
Original line number Diff line number Diff line
@@ -3115,13 +3115,9 @@ static noinline int do_init_module(struct module *mod) 


		goto fail_free_freeinit;

	}

	if (ret > 0) {

		pr_warn("%s: '%s'->init suspiciously returned %d, it should "

			"follow 0/-E convention\n"

			"%s: loading module anyway...\n",

			__func__, mod->name, ret, __func__);

		dump_stack();

	}

	if (ret > 0)

		pr_warn("%s: init suspiciously returned %d, it should follow 0/-E convention\n",

			mod->name, ret);



	/* Now it's a first class citizen! */

	mod->state = MODULE_STATE_LIVE;