Commit 66539952 authored by Honggyu Kim's avatar Honggyu Kim Committed by Andrew Morton
Browse files

mm/damon/core: remove duplicate list_empty quota->goals check 

damos_set_effective_quota() checks quota contidions but there are some
duplicate checks for quota->goals inside.

This patch reduces one of if statement to simplify the esz calculation
logic by setting esz as ULONG_MAX by default.

Link: https://lkml.kernel.org/r/20241125184307.41746-1-sj@kernel.org


Signed-off-by: default avatarHonggyu Kim <honggyu.kim@sk.com>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 9aec2fb0

mm/damon/core.c

+2 −5
Original line number Diff line number Diff line
@@ -1550,7 +1550,7 @@ static unsigned long damos_quota_score(struct damos_quota *quota) 
static void damos_set_effective_quota(struct damos_quota *quota)

{

	unsigned long throughput;

	unsigned long esz;

	unsigned long esz = ULONG_MAX;



	if (!quota->ms && list_empty(&quota->goals)) {

		quota->esz = quota->sz;
@@ -1572,10 +1572,7 @@ static void damos_set_effective_quota(struct damos_quota *quota) 
				quota->total_charged_ns;

		else

			throughput = PAGE_SIZE * 1024;

		if (!list_empty(&quota->goals))

		esz = min(throughput * quota->ms, esz);

		else

			esz = throughput * quota->ms;

	}



	if (quota->sz && quota->sz < esz)