Commit 6657d899 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Jiri Kosina
Browse files

HID: intel-ish-hid: Remove unused ishtp_cl_tx_empty 



ishtp_cl_tx_empty() was added in 2018 by
commit a1c40ce6 ("HID: intel-ish-hid: ishtp: add helper functions for
client buffer operation") but has remained unused.

Remove it.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Acked-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent c59c46ca

drivers/hid/intel-ish-hid/ishtp/client-buffers.c

+0 −21
Original line number Diff line number Diff line
@@ -251,27 +251,6 @@ int ishtp_cl_io_rb_recycle(struct ishtp_cl_rb *rb) 
}

EXPORT_SYMBOL(ishtp_cl_io_rb_recycle);



/**

 * ishtp_cl_tx_empty() -test whether client device tx buffer is empty

 * @cl: Pointer to client device instance

 *

 * Look client device tx buffer list, and check whether this list is empty

 *

 * Return: true if client tx buffer list is empty else false

 */

bool ishtp_cl_tx_empty(struct ishtp_cl *cl)

{

	int tx_list_empty;

	unsigned long tx_flags;



	spin_lock_irqsave(&cl->tx_list_spinlock, tx_flags);

	tx_list_empty = list_empty(&cl->tx_list.list);

	spin_unlock_irqrestore(&cl->tx_list_spinlock, tx_flags);



	return !!tx_list_empty;

}

EXPORT_SYMBOL(ishtp_cl_tx_empty);



/**

 * ishtp_cl_rx_get_rb() -Get a rb from client device rx buffer list

 * @cl: Pointer to client device instance

include/linux/intel-ish-client-if.h

+0 −1
Original line number Diff line number Diff line
@@ -100,7 +100,6 @@ void ishtp_cl_destroy_connection(struct ishtp_cl *cl, bool reset); 
int ishtp_cl_send(struct ishtp_cl *cl, uint8_t *buf, size_t length);

int ishtp_cl_flush_queues(struct ishtp_cl *cl);

int ishtp_cl_io_rb_recycle(struct ishtp_cl_rb *rb);

bool ishtp_cl_tx_empty(struct ishtp_cl *cl);

struct ishtp_cl_rb *ishtp_cl_rx_get_rb(struct ishtp_cl *cl);

void *ishtp_get_client_data(struct ishtp_cl *cl);

void ishtp_set_client_data(struct ishtp_cl *cl, void *data);