Commit 666c53e9 authored by Jared Kangas's avatar Jared Kangas Committed by Vinod Koul
Browse files

dmaengine: fsl-edma: don't explicitly disable clocks in .remove() 



The clocks in fsl_edma_engine::muxclk are allocated and enabled with
devm_clk_get_enabled(), which automatically cleans these resources up,
but these clocks are also manually disabled in fsl_edma_remove(). This
causes warnings on driver removal for each clock:

        edma_module already disabled
        WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1200 clk_core_disable+0x198/0x1c8
        [...]
        Call trace:
         clk_core_disable+0x198/0x1c8 (P)
         clk_disable+0x34/0x58
         fsl_edma_remove+0x74/0xe8 [fsl_edma]
         [...]
        ---[ end trace 0000000000000000 ]---
        edma_module already unprepared
        WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1059 clk_core_unprepare+0x1f8/0x220
        [...]
        Call trace:
         clk_core_unprepare+0x1f8/0x220 (P)
         clk_unprepare+0x34/0x58
         fsl_edma_remove+0x7c/0xe8 [fsl_edma]
         [...]
        ---[ end trace 0000000000000000 ]---

Fix these warnings by removing the unnecessary fsl_disable_clocks() call
in fsl_edma_remove().

Fixes: a9903de3 ("dmaengine: fsl-edma: refactor using devm_clk_get_enabled")
Signed-off-by: default avatarJared Kangas <jkangas@redhat.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260113-fsl-edma-clock-removal-v1-1-2025b49e7bcc@redhat.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3c8a86ed

drivers/dma/fsl-edma-main.c

+0 −1
Original line number Diff line number Diff line
@@ -915,7 +915,6 @@ static void fsl_edma_remove(struct platform_device *pdev) 
	of_dma_controller_free(np);

	dma_async_device_unregister(&fsl_edma->dma_dev);

	fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);

	fsl_disable_clocks(fsl_edma, fsl_edma->drvdata->dmamuxs);

}



static int fsl_edma_suspend_late(struct device *dev)