Commit 666d2206 authored by James Clark's avatar James Clark Committed by Namhyung Kim
Browse files

perf tests: Fix "PE file support" test build 



filename__read_build_id() now takes a blocking/non-blocking argument.
The original behavior of filename__read_build_id() was blocking so add
block=true to fix the build.

Fixes: 2c369d91 ("perf symbol: Add blocking argument to filename__read_build_id")
Signed-off-by: default avatarJames Clark <james.clark@linaro.org>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Reviewed-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Link: https://lore.kernel.org/r/20250903-james-perf-read-build-id-fix-v1-1-6a694d0a980f@linaro.org


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 01be43f2

tools/perf/tests/pe-file-parsing.c

+2 −2
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ static int run_dir(const char *d) 
	size_t idx;



	scnprintf(filename, PATH_MAX, "%s/pe-file.exe", d);

	ret = filename__read_build_id(filename, &bid);

	ret = filename__read_build_id(filename, &bid, /*block=*/true);

	TEST_ASSERT_VAL("Failed to read build_id",

			ret == sizeof(expect_build_id));

	TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id,
@@ -49,7 +49,7 @@ static int run_dir(const char *d) 
			!strcmp(debuglink, expect_debuglink));



	scnprintf(debugfile, PATH_MAX, "%s/%s", d, debuglink);

	ret = filename__read_build_id(debugfile, &bid);

	ret = filename__read_build_id(debugfile, &bid, /*block=*/true);

	TEST_ASSERT_VAL("Failed to read debug file build_id",

			ret == sizeof(expect_build_id));

	TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id,