Unverified Commit 666e6f39 authored by Macpaul Lin's avatar Macpaul Lin Committed by AngeloGioacchino Del Regno
Browse files

arm64: dts: mediatek: mt8395-genio-1200-evk: add u3port1 for xhci1

This patch fixes an issue where xhci1 was not functioning properly because
the state and PHY settings were incorrect.

The introduction of the 'force-mode' property in the phy-mtk-tphy driver
allows for the correct initialization of xhci1 by updating the Device Tree
settings accordingly.

The necessary fixup which added support for the 'force-mode' switch in the
phy-mtk-tphy driver.
commit 9b273030 ("phy: mediatek: tphy: add support force phy mode switch")
Link: https://lore.kernel.org/r/20231211025624.28991-2-chunfeng.yun@mediatek.com



Prior to this fix, the system would exhibit the following probe failure messages
for xhci1:
  xhci-mtk 11290000.usb: supply vbus not found, using dummy regulator
  xhci-mtk 11290000.usb: uwk - reg:0x400, version:104
  xhci-mtk 11290000.usb: xHCI Host Controller
  xhci-mtk 11290000.usb: new USB bus registered, assigned bus number 5
  xhci-mtk 11290000.usb: clocks are not stable (0x1003d0f)
  xhci-mtk 11290000.usb: can't setup: -110
  xhci-mtk 11290000.usb: USB bus 5 deregistered
  xhci-mtk: probe of 11290000.usb failed with error -110

With the application of this dts fixup, the aforementioned initialization errors
are resolved and xhci1 is working.

Signed-off-by: default avatarMacpaul Lin <macpaul.lin@mediatek.com>
Link: https://lore.kernel.org/r/20240216095751.4937-1-macpaul.lin@mediatek.com


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 52b7afd5
Loading
Loading
Loading
Loading
+6 −0
Original line number Diff line number Diff line
@@ -854,6 +854,10 @@ &u3phy0 {

&u3phy1 {
	status = "okay";

	u3port1: usb-phy@700 {
		mediatek,force-mode;
	};
};

&u3phy2 {
@@ -900,6 +904,8 @@ &xhci0 {
};

&xhci1 {
	phys = <&u2port1 PHY_TYPE_USB2>,
	       <&u3port1 PHY_TYPE_USB3>;
	vusb33-supply = <&mt6359_vusb_ldo_reg>;
	status = "okay";
};