Commit 66d4374d authored by David Lechner's avatar David Lechner Committed by Jonathan Cameron
Browse files

iio: adc: ad_sigma_delta: change to buffer predisable 



Change the buffer disable callback from postdisable to predisable.
This balances the existing posteanble callback. Using postdisable
with posteanble can be problematic, for example, if update_scan_mode
fails, it would call postdisable without ever having called posteanble,
so the drivers using this would be in an unexpected state when
postdisable was called.

Fixes: af300848 ("iio:adc: Add common code for ADI Sigma Delta devices")
Signed-off-by: default avatarDavid Lechner <dlechner@baylibre.com>
Reviewed-by: default avatarNuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250703-iio-adc-ad_sigma_delta-buffer-predisable-v1-1-f2ab85138f1f@baylibre.com


Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 9b71d269

drivers/iio/adc/ad_sigma_delta.c

+2 −2
Original line number Diff line number Diff line
@@ -582,7 +582,7 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev) 
	return ret;

}



static int ad_sd_buffer_postdisable(struct iio_dev *indio_dev)

static int ad_sd_buffer_predisable(struct iio_dev *indio_dev)

{

	struct ad_sigma_delta *sigma_delta = iio_device_get_drvdata(indio_dev);
@@ -682,7 +682,7 @@ static bool ad_sd_validate_scan_mask(struct iio_dev *indio_dev, const unsigned l 


static const struct iio_buffer_setup_ops ad_sd_buffer_setup_ops = {

	.postenable = &ad_sd_buffer_postenable,

	.postdisable = &ad_sd_buffer_postdisable,

	.predisable = &ad_sd_buffer_predisable,

	.validate_scan_mask = &ad_sd_validate_scan_mask,

};