Unverified Commit 66e245db authored by Alok Tiwari's avatar Alok Tiwari Committed by Ilpo Järvinen
Browse files

platform/x86/intel/pmt/discovery: use valid device pointer in dev_err_probe 



The PMT feature probe creates a child device with device_create().
If device creation fail, the code pass priv->dev (which is an ERR_PTR)
to dev_err_probe(), which is not a valid device pointer.

This patch change the dev_err_probe() call to use the parent auxiliary
device (&auxdev->dev) and update the error message to reference the
parent device name. It ensure correct error reporting and avoid
passing an invalid device pointer.

Fixes: d9a07880 ("platform/x86/intel/pmt: Add PMT Discovery driver")
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20251224095133.115678-1-alok.a.tiwari@oracle.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent e44c42c8

drivers/platform/x86/intel/pmt/discovery.c

+2 −2
Original line number Diff line number Diff line
@@ -548,9 +548,9 @@ static int pmt_features_probe(struct auxiliary_device *auxdev, const struct auxi 
	priv->dev = device_create(&intel_pmt_class, &auxdev->dev, MKDEV(0, 0), priv,

				  "%s-%s", "features", dev_name(priv->parent));

	if (IS_ERR(priv->dev))

		return dev_err_probe(priv->dev, PTR_ERR(priv->dev),

		return dev_err_probe(&auxdev->dev, PTR_ERR(priv->dev),

				     "Could not create %s-%s device node\n",

				     "features", dev_name(priv->dev));

				     "features", dev_name(priv->parent));



	/* Initialize each feature */

	for (i = 0; i < ivdev->num_resources; i++) {