Unverified Commit 66e9feb0 authored by Hans de Goede's avatar Hans de Goede Committed by Mark Brown
Browse files

spi: Add TODO comment about ACPI GPIO setup 



Add a TODO comment that ideally the ACPI/gpiolib core code should take care
of setting GPIO direction and/or bias according to ACPI GPIO resources.

If this TODO gets implemented then the acpi_dev_gpio_irq_get() call in
acpi_register_spi_device() can be dropped.

Suggested-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <johannes.goede@oss.qualcomm.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Link: https://patch.msgid.link/20251109155340.26199-1-johannes.goede@oss.qualcomm.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 939edfaa

drivers/spi/spi.c

+2 −0
Original line number Diff line number Diff line
@@ -2857,6 +2857,8 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr, 
	 * here too, because this call sets the GPIO direction and/or bias.

	 * Setting these needs to be done even if there is no driver, in which

	 * case spi_probe() will never get called.

	 * TODO: ideally the setup of the GPIO should be handled in a generic

	 * manner in the ACPI/gpiolib core code.

	 */

	if (spi->irq < 0)

		spi->irq = acpi_dev_gpio_irq_get(adev, 0);