Commit 66f40b92 authored by Waiman Long's avatar Waiman Long Committed by Tejun Heo
Browse files

cgroup/cpuset: Fix a memory leak in update_exclusive_cpumask() 



Fix a possible memory leak in update_exclusive_cpumask() by moving the
alloc_cpumasks() down after the validate_change() check which can fail
and still before the temporary cpumasks are needed.

Fixes: e2ffe502 ("cgroup/cpuset: Add cpuset.cpus.exclusive for v2")
Reported-and-tested-by: default avatarMirsad Todorovac <mirsad.todorovac@alu.hr>
Closes: https://lore.kernel.org/lkml/14915689-27a3-4cd8-80d2-9c30d0c768b6@alu.unizg.hr


Signed-off-by: default avatarWaiman Long <longman@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # v6.7+
parent e326df53

kernel/cgroup/cpuset.c

+3 −3
Original line number Diff line number Diff line
@@ -2598,9 +2598,6 @@ static int update_exclusive_cpumask(struct cpuset *cs, struct cpuset *trialcs, 
	if (cpumask_equal(cs->exclusive_cpus, trialcs->exclusive_cpus))

		return 0;



	if (alloc_cpumasks(NULL, &tmp))

		return -ENOMEM;



	if (*buf)

		compute_effective_exclusive_cpumask(trialcs, NULL);
@@ -2615,6 +2612,9 @@ static int update_exclusive_cpumask(struct cpuset *cs, struct cpuset *trialcs, 
	if (retval)

		return retval;



	if (alloc_cpumasks(NULL, &tmp))

		return -ENOMEM;



	if (old_prs) {

		if (cpumask_empty(trialcs->effective_xcpus)) {

			invalidate = true;