Commit 671ca05d authored by Lucas De Marchi's avatar Lucas De Marchi Committed by Rodrigo Vivi
Browse files

drm/xe: Make local functions static 



A few static functions not being declared like that break the build with
W=1, like e.g.

	cc1: all warnings being treated as errors
	make[2]: *** [../scripts/Makefile.build:250: drivers/gpu/drm/xe/xe_gt.o] Error 1
	../drivers/gpu/drm/xe/xe_guc.c:240:6: error: no previous prototype for ‘guc_write_params’ [-Werror=missing-prototypes]
	  240 | void guc_write_params(struct xe_guc *guc)
	      |      ^~~~~~~~~~~~~~~~

Make them static.

Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent b47b0ef1

drivers/gpu/drm/xe/xe_gt.c

+3 −3
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static void gt_fini(struct drm_device *drm, void *arg) 


static void gt_reset_worker(struct work_struct *w);



int emit_nop_job(struct xe_gt *gt, struct xe_engine *e)

static int emit_nop_job(struct xe_gt *gt, struct xe_engine *e)

{

	struct xe_sched_job *job;

	struct xe_bb *bb;
@@ -252,7 +252,7 @@ int emit_nop_job(struct xe_gt *gt, struct xe_engine *e) 
	return 0;

}



int emit_wa_job(struct xe_gt *gt, struct xe_engine *e)

static int emit_wa_job(struct xe_gt *gt, struct xe_engine *e)

{

	struct xe_reg_sr *sr = &e->hwe->reg_lrc;

	struct xe_reg_sr_entry *entry;
@@ -609,7 +609,7 @@ int xe_gt_init(struct xe_gt *gt) 
	return 0;

}



int do_gt_reset(struct xe_gt *gt)

static int do_gt_reset(struct xe_gt *gt)

{

	struct xe_device *xe = gt_to_xe(gt);

	int err;

drivers/gpu/drm/xe/xe_guc.c

+2 −2
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ static void guc_init_params(struct xe_guc *guc) 
 * transfer. These parameters are read by the firmware on startup

 * and cannot be changed thereafter.

 */

void guc_write_params(struct xe_guc *guc)

static void guc_write_params(struct xe_guc *guc)

{

	struct xe_gt *gt = guc_to_gt(guc);

	int i;
@@ -560,7 +560,7 @@ static void guc_handle_mmio_msg(struct xe_guc *guc) 
			"Received early GuC exception notification!\n");

}



void guc_enable_irq(struct xe_guc *guc)

static void guc_enable_irq(struct xe_guc *guc)

{

	struct xe_gt *gt = guc_to_gt(guc);

	u32 events = xe_gt_is_media_type(gt) ?

drivers/gpu/drm/xe/xe_irq.c

+1 −1
Original line number Diff line number Diff line
@@ -448,7 +448,7 @@ static void dg1_irq_reset(struct xe_gt *gt) 
	GEN3_IRQ_RESET(gt, GEN8_PCU_);

}



void xe_irq_reset(struct xe_device *xe)

static void xe_irq_reset(struct xe_device *xe)

{

	struct xe_gt *gt;

	u8 id;

drivers/gpu/drm/xe/xe_wait_user_fence.c

+3 −3
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ static const enum xe_engine_class user_to_xe_engine_class[] = { 
	[DRM_XE_ENGINE_CLASS_COMPUTE] = XE_ENGINE_CLASS_COMPUTE,

};



int check_hw_engines(struct xe_device *xe,

static int check_hw_engines(struct xe_device *xe,

			    struct drm_xe_engine_class_instance *eci,

			    int num_engines)

{