Unverified Commit 672820a0 authored by Antonio Quartulli's avatar Antonio Quartulli Committed by Christian Brauner
Browse files

ovl: properly print correct variable 



In case of ovl_lookup_temp() failure, we currently print `err`
which is actually not initialized at all.

Instead, properly print PTR_ERR(whiteout) which is where the
actual error really is.

Address-Coverity-ID: 1647983 ("Uninitialized variables  (UNINIT)")
Fixes: 8afa0a73 ("ovl: narrow locking in ovl_whiteout()")
Signed-off-by: default avatarAntonio Quartulli <antonio@mandelbit.com>
Link: https://lore.kernel.org/20250721203821.7812-1-antonio@mandelbit.com


Reviewed-by: default avatarNeilBrown <neil@brown.name>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent dc397785

fs/overlayfs/dir.c

+3 −2
Original line number Diff line number Diff line
@@ -117,8 +117,9 @@ static struct dentry *ovl_whiteout(struct ovl_fs *ofs) 
		if (!IS_ERR(whiteout))

			return whiteout;

		if (PTR_ERR(whiteout) != -EMLINK) {

			pr_warn("Failed to link whiteout - disabling whiteout inode sharing(nlink=%u, err=%i)\n",

				ofs->whiteout->d_inode->i_nlink, err);

			pr_warn("Failed to link whiteout - disabling whiteout inode sharing(nlink=%u, err=%lu)\n",

				ofs->whiteout->d_inode->i_nlink,

				PTR_ERR(whiteout));

			ofs->no_shared_whiteout = true;

		}

	}