Commit 67283a5c authored by Umang Jain's avatar Umang Jain Committed by Greg Kroah-Hartman
Browse files

staging: vchiq_core: Lower indentation in vchiq_close_service_internal 



Reduce indentation of the conditional nesting in
vchiq_close_service_internal() switch case by checking the error paths
first and break early. This helps to reduce conditional branching and
reduce indentation levels.

Signed-off-by: default avatarUmang Jain <umang.jain@ideasonboard.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241013112128.397249-7-umang.jain@ideasonboard.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8cea95f4

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

+13 −11
Original line number Diff line number Diff line
@@ -3163,7 +3163,12 @@ vchiq_close_service_internal(struct vchiq_service *service, int close_recvd) 
		if (close_recvd) {

			dev_err(state->dev, "core: (1) called in state %s\n",

				srvstate_names[service->srvstate]);

		} else if (is_server) {

			break;

		} else if (!is_server) {

			vchiq_free_service_internal(service);

			break;

		}



		if (service->srvstate == VCHIQ_SRVSTATE_LISTENING) {

			status = -EINVAL;

		} else {
@@ -3173,9 +3178,6 @@ vchiq_close_service_internal(struct vchiq_service *service, int close_recvd) 
				set_service_state(service, VCHIQ_SRVSTATE_LISTENING);

		}

		complete(&service->remove_event);

		} else {

			vchiq_free_service_internal(service);

		}

		break;

	case VCHIQ_SRVSTATE_OPENING:

		if (close_recvd) {