Commit 67332702 authored by Mark Brown's avatar Mark Brown Committed by Jassi Brar
Browse files

mailbox: pcc: Remove spurious IRQF_ONESHOT usage 



The PCC code currently specifies IRQF_ONESHOT if the interrupt could
potentially be shared but doesn't actually use request_threaded_irq() and
the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
never relevant. Since commit aef30c8d ("genirq: Warn about using
IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
WARN_ON(), fix this by removing IRQF_ONESHOT.

Reported-by: default avatarAishwarya TCV <Aishwarya.TCV@arm.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Reviewed-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
parent 244d11ae

drivers/mailbox/pcc.c

+1 −1
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ static int pcc_startup(struct mbox_chan *chan) 


	if (pchan->plat_irq > 0) {

		irqflags = pcc_chan_plat_irq_can_be_shared(pchan) ?

						IRQF_SHARED | IRQF_ONESHOT : 0;

						IRQF_SHARED : 0;

		rc = devm_request_irq(chan->mbox->dev, pchan->plat_irq, pcc_mbox_irq,

				      irqflags, MBOX_IRQ_NAME, chan);

		if (unlikely(rc)) {