Commit 67440850 authored by Zhen Ni's avatar Zhen Ni Committed by Krzysztof Kozlowski
Browse files

memory: samsung: exynos-srom: Fix of_iomap leak in exynos_srom_probe 



The of_platform_populate() call at the end of the function has a
possible failure path, causing a resource leak.

Replace of_iomap() with devm_platform_ioremap_resource() to ensure
automatic cleanup of srom->reg_base.

This issue was detected by smatch static analysis:
drivers/memory/samsung/exynos-srom.c:155 exynos_srom_probe()warn:
'srom->reg_base' from of_iomap() not released on lines: 155.

Fixes: 8ac2266d ("memory: samsung: exynos-srom: Add support for bank configuration")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarZhen Ni <zhen.ni@easystack.cn>
Link: https://lore.kernel.org/r/20250806025538.306593-1-zhen.ni@easystack.cn


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent d140f3ba

drivers/memory/samsung/exynos-srom.c

+4 −6
Original line number Diff line number Diff line
@@ -121,20 +121,18 @@ static int exynos_srom_probe(struct platform_device *pdev) 
		return -ENOMEM;



	srom->dev = dev;

	srom->reg_base = of_iomap(np, 0);

	if (!srom->reg_base) {

	srom->reg_base = devm_platform_ioremap_resource(pdev, 0);

	if (IS_ERR(srom->reg_base)) {

		dev_err(&pdev->dev, "iomap of exynos srom controller failed\n");

		return -ENOMEM;

		return PTR_ERR(srom->reg_base);

	}



	platform_set_drvdata(pdev, srom);



	srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,

						      ARRAY_SIZE(exynos_srom_offsets));

	if (!srom->reg_offset) {

		iounmap(srom->reg_base);

	if (!srom->reg_offset)

		return -ENOMEM;

	}



	for_each_child_of_node(np, child) {

		if (exynos_srom_configure_bank(srom, child)) {