Commit 676c7af9 authored by Felix Gu's avatar Felix Gu Committed by Jakub Kicinski
Browse files

dpll: zl3073x: Remove redundant cleanup in devm_dpll_init() 



The devm_add_action_or_reset() function already executes the cleanup
action on failure before returning an error, so the explicit goto error
and subsequent zl3073x_dev_dpll_fini() call causes double cleanup.

Fixes: ebb1031c ("dpll: zl3073x: Refactor DPLL initialization")
Reviewed-by: default avatarIvan Vecera <ivecera@redhat.com>
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260224-dpll-v2-1-d7786414a830@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7c9db1a1

drivers/dpll/zl3073x/core.c

+1 −5
Original line number Diff line number Diff line
@@ -981,11 +981,7 @@ zl3073x_devm_dpll_init(struct zl3073x_dev *zldev, u8 num_dplls) 
	}



	/* Add devres action to release DPLL related resources */

	rc = devm_add_action_or_reset(zldev->dev, zl3073x_dev_dpll_fini, zldev);

	if (rc)

		goto error;



	return 0;

	return devm_add_action_or_reset(zldev->dev, zl3073x_dev_dpll_fini, zldev);



error:

	zl3073x_dev_dpll_fini(zldev);