Commit 67c1ba55 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: module: make module_[add|remove]_driver take a const * 

The functions module_add_driver() and module_remove_driver() do not
modify the struct device_driver structure directly, so they are safe to
be marked as a constant pointer type.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/2024070850-entering-grandson-205e@gregkh


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8fb4691

drivers/base/base.h

+2 −2
Original line number Diff line number Diff line
@@ -192,8 +192,8 @@ extern struct kset *devices_kset; 
void devices_kset_move_last(struct device *dev);



#if defined(CONFIG_MODULES) && defined(CONFIG_SYSFS)

int module_add_driver(struct module *mod, struct device_driver *drv);

void module_remove_driver(struct device_driver *drv);

int module_add_driver(struct module *mod, const struct device_driver *drv);

void module_remove_driver(const struct device_driver *drv);

#else

static inline int module_add_driver(struct module *mod,

				    struct device_driver *drv)

drivers/base/module.c

+3 −3
Original line number Diff line number Diff line
@@ -9,7 +9,7 @@ 
#include <linux/string.h>

#include "base.h"



static char *make_driver_name(struct device_driver *drv)

static char *make_driver_name(const struct device_driver *drv)

{

	char *driver_name;
@@ -30,7 +30,7 @@ static void module_create_drivers_dir(struct module_kobject *mk) 
	mutex_unlock(&drivers_dir_mutex);

}



int module_add_driver(struct module *mod, struct device_driver *drv)

int module_add_driver(struct module *mod, const struct device_driver *drv)

{

	char *driver_name;

	struct module_kobject *mk = NULL;
@@ -89,7 +89,7 @@ int module_add_driver(struct module *mod, struct device_driver *drv) 
	return ret;

}



void module_remove_driver(struct device_driver *drv)

void module_remove_driver(const struct device_driver *drv)

{

	struct module_kobject *mk = NULL;

	char *driver_name;