Commit 67caa528 authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

ublk: fix narrowing warnings in UAPI header 



When a C++ file compiled with -Wc++11-narrowing includes the UAPI header
linux/ublk_cmd.h, ublk_sqe_addr_to_auto_buf_reg()'s assignments of u64
values to u8, u16, and u32 fields result in compiler warnings. Add
explicit casts to the intended types to avoid these warnings. Drop the
unnecessary bitmasks.

Reported-by: default avatarUday Shankar <ushankar@purestorage.com>
Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Fixes: 99c1e4eb ("ublk: register buffer to local io_uring with provided buf index via UBLK_F_AUTO_BUF_REG")
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250621162842.337452-1-csander@purestorage.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5223372e

include/uapi/linux/ublk_cmd.h

+4 −4
Original line number Diff line number Diff line
@@ -450,10 +450,10 @@ static inline struct ublk_auto_buf_reg ublk_sqe_addr_to_auto_buf_reg( 
		__u64 sqe_addr)

{

	struct ublk_auto_buf_reg reg = {

		.index = sqe_addr & 0xffff,

		.flags = (sqe_addr >> 16) & 0xff,

		.reserved0 = (sqe_addr >> 24) & 0xff,

		.reserved1 = sqe_addr >> 32,

		.index = (__u16)sqe_addr,

		.flags = (__u8)(sqe_addr >> 16),

		.reserved0 = (__u8)(sqe_addr >> 24),

		.reserved1 = (__u32)(sqe_addr >> 32),

	};



	return reg;