Commit 67cdd3a5 authored Jan 26, 2023 by Tom Rix Committed by Alex Deucher Feb 03, 2023

drm/amd/display: reduce else-if to else in dcn10_blank_pixel_data()



checkpatch reports
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: style:
  Expression is always true because 'else if' condition is opposite to previous condition at line 2895. [multiCondition]
 } else if (blank) {
            ^
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2895:6: note: first condition
 if (!blank) {
     ^
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: note: else if condition is opposite to first condition
 } else if (blank) {

It is not necessary to explicitly the check != condition, an else is simplier.

Fixes: aa5a5777 ("drm/amd/display: Vari-bright looks disabled near end of MM14")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 65a4cfb4

drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2899,7 +2899,7 @@ void dcn10_blank_pixel_data(
		dc->hwss.set_pipe(pipe_ctx);
		stream_res->abm->funcs->set_abm_level(stream_res->abm, stream->abm_level);
		}
		} else if (blank) {
		} else {
		dc->hwss.set_abm_immediate_disable(pipe_ctx);
		if (stream_res->tg->funcs->set_blank) {
		stream_res->tg->funcs->wait_for_state(stream_res->tg, CRTC_STATE_VBLANK);