Commit 68016b99 authored by Hongbo Li's avatar Hongbo Li Committed by Jakub Kicinski
Browse files

net: prefer strscpy over strcpy 

The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy

 [1]

Signed-off-by: default avatarHongbo Li <lihongbo22@huawei.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3cbd2090

net/core/dev.c

+1 −1
Original line number Diff line number Diff line
@@ -11143,7 +11143,7 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name, 
	if (!dev->ethtool)

		goto free_all;



	strcpy(dev->name, name);

	strscpy(dev->name, name);

	dev->name_assign_type = name_assign_type;

	dev->group = INIT_NETDEV_GROUP;

	if (!dev->ethtool_ops)