Commit 680ad315 authored by Haoxiang Li's avatar Haoxiang Li Committed by Thomas Bogendoerfer
Browse files

MIPS: Fix a reference leak bug in ip22_check_gio() 



If gio_device_register fails, gio_dev_put() is required to
drop the gio_dev device reference.

Fixes: e84de0c6 ("MIPS: GIO bus support for SGI IP22/28")
Signed-off-by: default avatarHaoxiang Li <haoxiang_li2024@163.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent bd94fbe8

arch/mips/sgi-ip22/ip22-gio.c

+2 −1
Original line number Diff line number Diff line
@@ -372,7 +372,8 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq) 
		gio_dev->resource.flags = IORESOURCE_MEM;

		gio_dev->irq = irq;

		dev_set_name(&gio_dev->dev, "%d", slotno);

		gio_device_register(gio_dev);

		if (gio_device_register(gio_dev))

			gio_dev_put(gio_dev);

	} else

		printk(KERN_INFO "GIO: slot %d : Empty\n", slotno);

}