Commit 68477b5d authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: fix rename failure 



I found that rename fails after cifs mount due to update of
lookup_one_qstr_excl().

 mv a/c b/
mv: cannot move 'a/c' to 'b/c': No such file or directory

In order to rename to a new name regardless of whether the dentry is
negative, we need to get the dentry through lookup_one_qstr_excl().
So It will not return error if the name doesn't exist.

Fixes: 204a575e ("VFS: add common error checks to lookup_one_qstr_excl()")
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 1f4bbedd

fs/smb/server/vfs.c

+1 −1
Original line number Diff line number Diff line
@@ -682,7 +682,7 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path, 
	struct ksmbd_file *parent_fp;

	int new_type;

	int err, lookup_flags = LOOKUP_NO_SYMLINKS;

	int target_lookup_flags = LOOKUP_RENAME_TARGET;

	int target_lookup_flags = LOOKUP_RENAME_TARGET | LOOKUP_CREATE;



	if (ksmbd_override_fsids(work))

		return -ENOMEM;