Commit 684890a0 authored by John Keeping's avatar John Keeping Committed by Dmitry Torokhov
Browse files

Input: adc-joystick - fix optional value handling 



The abs-fuzz and abs-flat properties are documented as optional.  When
these are absent, fwnode_property_read_u32() will leave the input
unchanged, meaning that an axis either picks up the value for the
previous axis or an uninitialized value.

Explicitly set these values to zero when they are unspecified to match
the documented behaviour in the device tree bindings.

Signed-off-by: default avatarJohn Keeping <jkeeping@inmusicbrands.com>
Link: https://lore.kernel.org/r/20240731093310.3696919-1-jkeeping@inmusicbrands.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent da897484

drivers/input/joystick/adc-joystick.c

+5 −2
Original line number Diff line number Diff line
@@ -182,8 +182,11 @@ static int adc_joystick_set_axes(struct device *dev, struct adc_joystick *joy) 
			swap(range[0], range[1]);

		}



		fwnode_property_read_u32(child, "abs-fuzz", &fuzz);

		fwnode_property_read_u32(child, "abs-flat", &flat);

		if (fwnode_property_read_u32(child, "abs-fuzz", &fuzz))

			fuzz = 0;



		if (fwnode_property_read_u32(child, "abs-flat", &flat))

			flat = 0;



		input_set_abs_params(joy->input, axes[i].code,

				     range[0], range[1], fuzz, flat);